Yarn add OpenZeppelin Contracts 2.5.1

[Graeme_Barnes]

Hi @abcoathup , I think I have a similar issue to @wat .

My project uses an interface which requires open zepplins IERC20 contracts, the catch is that it is in solidity version 0.5.

I tried installing

@abcoathup

npm install @openzeppelin/contracts@2.5.1

However I get:

error An unexpected error occurred: “https://registry.yarnpkg.com/openzeppelin%2Fcontracts: Request “https://registry.yarnpkg.com/openzeppelin%2Fcontracts” returned a 405”.

I am using yarn add, that could be the source of the issue, justt checking if you guys still support openzeppelin/contracts@2.5.1 package?

[abcoathup]

Hi @Graeme_Barnes,

Welcome to the community

You can use OpenZeppelin Contracts 2.5.1

You should be able to do yarn add @openzeppelin/contracts@2.5.1

$ yarn add @openzeppelin/contracts@2.5.1
yarn add v1.22.4
info No lockfile found.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...

success Saved lockfile.
warning Your current version of Yarn is out of date. The latest version is "1.22.5", while you're on "1.22.4".
info To upgrade, run the following command:
$ sudo apt-get update && sudo apt-get install yarn
success Saved 1 new dependency.
info Direct dependencies
└─ @openzeppelin/contracts@2.5.1
info All dependencies
└─ @openzeppelin/contracts@2.5.1
Done in 1.37s.

[Graeme_Barnes]

@abcoathup

yarn add @openzeppelin/contracts@2.5.1

That you very much for the quick reply. It was an error on my side, I didn’t add the @ symbol in front of the package name.

Not sure if other dev’s have run into this issue but my project requires open zepplin’s solidity V5 and V6. Open zepplin’s version write over each in the dependancy file. I expect this is normal behaviour, but its breaking my project.

Do you have any tips for having two version of open zepplin’s contracts in one project?

[Graeme_Barnes]

@abcoathup

yarn add @openzeppelin/contracts@2.5.1

trying out Yarn’s alias command.

Yarn

with command: yarn add openzepplin-v5@npm:openzeppelin/contracts@2.5.1

But unfortunately compiler throws up this is:

An unexpected error occurred: “https://registry.yarnpkg.com/openzeppelin%2Fcontracts: Request returned a 405”.

Guess I’m formatting the command incorrectly .

[Graeme_Barnes]

Correct command was

yarn add openzepplin-v5@npm:@openzeppelin/contracts@2.5.1. I’ll update on the thread if this works when working with two version of open zepplin.

[Graeme_Barnes]

Whoop, looks like that did the trick

[sven.meyer]

I was about to ask a similar question.

I currently have "@openzeppelin/contracts": "^3.3.0" in my truffle dependencies, but would also need 2.5.1 (!) because I want to add a Crowdsale … can I use both?

@Graeme_Barnes is yarn add openzepplin-v5@npm:@openzeppelin/contracts@2.5.1 actaully doing what I want ?

@abcoathup is there more documentation and maybe even examples for Crowdsale then (more of less) just the function names ?

[Graeme_Barnes]

Hey, ya this works for my project in hardhat. Basically I’ve got on solidity file in solidity version 0.5 which requires the openzeppelin contracts 2.5.1.

However I’ve got another solidity file in version 0.6 which requires open zepplin’s ownable module and a few others.

If you go ahead and run yarn add open zepplin/contracts it will over write the old contracts 2.5.1.

Giving the 2.5.1 contracts alias just means that it wont over write the zepplin/contracts. This allows me to use an import statement like:

import "openzepplin-v5/token/ERC20/ERC20.sol";

whilst in my solidty version 0.6 contracts I have:
import "@openzeppelin/contracts/token/ERC20/IERC20.sol";

and yeah it works.

[abcoathup]

Hi @Graeme_Barnes & @sven.meyer,

Hardhat supports multiple Solidity versions in the same project. This isn’t supported in Truffle.
I haven’t tried running OpenZeppelin Contracts 2.x and OpenZeppelin Contracts 3.x in the same project though.

As for a Crowdsale, you could just have a separate project with your Crowdsale contract to use OpenZeppelin Contracts 2.5.1.

The Crowdsale documentation is here: https://docs.openzeppelin.com/contracts/2.x/crowdsales
There is a Simple ERC20 Crowdsale example in the forum too.

[sven.meyer]

@abcoathup

Going to setup a separate project for the Tokensale.
The other project uses truffle , OpenZeppelin contracts v3 andsolc 0.6.12

Can I define an interface in the , derived from the Cowdsale contracts which use solc 0.5.17 , and compile that with 0.6.12

Just wanted to make sure that the have not changed anything in the call interface …

// SPDX-License-Identifier: MIT

pragma solidity 0.6.12; // ^0.5.0;

// https://github.com/OpenZeppelin/openzeppelin-contracts/blob/release-v2.5.0/contracts/crowdsale/validation/IndividuallyCappedCrowdsale.sol
// https://github.com/OpenZeppelin/openzeppelin-contracts/blob/release-v2.5.0/contracts/access/roles/CapperRole.sol

interface IndividuallyCappedCrowdsaleInterface {

	/**
	* @dev Sets a specific beneficiary's maximum contribution.
	* @param beneficiary Address to be capped
	* @param cap Wei limit for individual contribution
	*/
	function setCap(address beneficiary, uint256 cap) external; /* onlyCapper */

	/**
     * @dev Returns the cap of a specific beneficiary.
     * @param beneficiary Address whose cap is to be checked
     * @return Current cap for individual beneficiary
     */
    function getCap(address beneficiary) external view returns (uint256);

	/**
     * @dev Returns the amount contributed so far by a specific beneficiary.
     * @param beneficiary Address of contributor
     * @return Beneficiary contribution so far
     */
    function getContribution(address beneficiary) external view returns (uint256);

	/**
	 * @dev Capper is the account/role allowed to execute setCap
	 */
	function isCapper(address account)  external view returns (bool);

    function addCapper(address account) external; /* onlyCapper */

    function renounceCapper() external;

}

[abcoathup]

Hi @sven.meyer,

I am not sure why you need to create a crowdsale interface. Are you planning to interact with your crowdsale from another contract?

You can just deploy your Crowdsale and interact with your token using IERC20.

[sven.meyer]

@abcoathup Exactly. The idea is to setup a IndividuallyCappedCrowdsale and have another contract which will determine how much a certain user will be allowed to purchase.
That other contract would have to call the setCap function.

I am still thinking what the right pattern would be to connect them:

1. Deploy the Crowdsale first and provide the crowdsale address to the constructor of the other contract

2. Deploy both contracts “as is” and execute a “setCrowdsaleAddress” thereafter (make it even "update-able by an admin , what could be regarded either as “convenient” or a “security risk”)

3. Have a 3rd “governance contract” to hold the addresses of each contract, which can be requested by the other contract. (potentially also update-able)

I think technically it all should work, I am just wondering what would be “good practice” ?

[UPDATE] ok, might work with a normal program, but if I change (set) a new address for an external contract, that does not (automatically) result in the contract updating the instance / reference to the external contract … so option 2) might not be a good solution, unless the ‘set’ is forced to be executed only once before use.

One more question : Can I sell a token for something else than ETH, like DAI, … ?

[abcoathup]

@sven.meyer

Can I sell a token for something else than ETH, like DAI, … ?

The Crowdsale contracts in OpenZeppelin Contracts 2.x only accept Ether. You could create your own crowdsale contract (using the concepts from Crowdsales) or you could look at using a decentralized exchange to sell tokens.