UUPSUpgradable delegatecall

Support Upgrades
1

Hello,

Currently, I have an upgradable erc20 contract and it all works fine. The only issue is when i make a V2 that uses the old contract but only has 1 new function inside it and i try to use upgradeTo on the old one and plug the new contract address .. i keep getting

"message": "execution reverted: Function must be called through delegatecall"

I am wondering if i missed anything or i am misunderstanding this function call.

Thank you

2

Ensure you are calling the function at the proxy contract address, not the implementation contract address. For reference, this is the source of that revert message: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/proxy/utils/UUPSUpgradeable.sol#L26

3

Not sure where that would be?

I launched the original contract and a V2 contract. The updradeTo is inside the first contract.
This is all in the evm of remix as well

4

An upgradable contract generally has two parts: a proxy contract and an implementation contract. These contracts are deployed to different addresses. You would need to deploy the implementation contract first (which is the contract that you wrote), then deploy a proxy contract (i.e. ERC1967Proxy for a UUPS proxy) to point to the implementation.

To simplify the above process, we recommend using the OpenZeppelin Upgrades Plugins which makes it easy to deploy and manage proxies using Hardhat or Truffle.

5

Does this mean that it can't be deployed from remix.ethereum and requires the plugins?

6

Yes, see the explanation here:

7

Hi,
Based on the source in @ericglau 's answer, I presume that the example presented on OpenZeppelin docs has a little mistake. The comparison inside checkDelegateCall function should be with self, right?

abstract contract OnlyDelegateCall {
    /// @custom:oz-upgrades-unsafe-allow state-variable-immutable state-variable-assignment
    address private immutable self = address(this);

    function checkDelegateCall() private view {
        require(address(this) != original);
    }

    modifier onlyDelegateCall() {
        checkDelegateCall();
        _;
    }
}

If it's correct my perception, how can we notify OpenZeppelin staff?

Regards,

8

@fabianorodrigo Thank you for reporting this issue. I've opened a PR for the docs here.

1 Like