Unexpected token in JSON - oz compile -> oz create build bug

gitpusha · November 14, 2019, 11:10am

Hi,

I found a new bug, similar to the one I already mentioned before:

Again, the oz compile command seems to generate a buggy build artifact.

See the problem in the JSON:

See the contract/interface code:

This time, I do not have duplicate names anywhere in my project. I only have this one file called IGelatoAction.sol and I only declare this one interface in that one file and import it elsewhere.

I can manually remove the unexpected token and this way continue my work (oz create the contract). But it is a weird bug I wanted to draw your attention to.

UPDATE:
Bug is als there in new oz --version 2.6

abcoathup · November 18, 2019, 3:37am

Hi @gitpusha,

Sorry to hear that you are having this issue.

Any thoughts on how to reproduce?

I have tried compiling with optimizer enabled/disabled and also commenting out one of the function declarations but haven’t seen the issue.

gitpusha · November 18, 2019, 9:27am

Hi, I have no clue yet on how to reproduce. I will play around a little once and report back, once I had some more time. Dont worry till then. Thank you!

abcoathup · November 19, 2019, 2:20am

Hi @gitpusha,

I saw it a couple of times when I was trying different things with the Gelato repo to identify the node 12 oz compile issue, though nothing that I could reproduce consistently.

gitpusha · November 20, 2019, 8:41am

Hi @abcoathup,

I noticed that the oz compile issue consistently (always) creeps up only in this file: build/IGelatoAction.json (not in version management).

Could it be that this happens due to the way IGelatoAction.sol is imported in our contracts:

Imported here:

github.com

gelatodigital/gelato/blob/c205a6a45118a90106bb1dda4b0d5339b2f247ba/contracts/gelato_core/GelatoCoreAccounting.sol#L3


pragma solidity ^0.5.10;


import './interfaces/triggers_actions_interfaces/IGelatoAction.sol';
import "@openzeppelin/contracts-ethereum-package/contracts/utils/Address.sol";
import "@openzeppelin/upgrades/contracts/Initializable.sol";
import '@openzeppelin/contracts-ethereum-package/contracts/ownership/Ownable.sol';
import '@openzeppelin/contracts-ethereum-package/contracts/utils/ReentrancyGuard.sol';
import '@openzeppelin/contracts-ethereum-package/contracts/math/SafeMath.sol';


/**
 * @title GelatoCoreAccounting
 * @notice non-deploy base contract
 */

Not imported directly here, but via inheritance:

github.com

gelatodigital/gelato/blob/c205a6a45118a90106bb1dda4b0d5339b2f247ba/contracts/gelato_core/GelatoCore.sol#L12




import './GelatoUserProxyManager.sol';
import './GelatoCoreAccounting.sol';
import '@openzeppelin/contracts-ethereum-package/contracts/drafts/Counters.sol';


/**
 * @title GelatoCore
 * @notice deployable contract
 */
contract GelatoCore is GelatoUserProxyManager,
                       GelatoCoreAccounting
{
    using Address for address payable;  /// for oz's sendValue method


    /// @dev initializer fn must call the initializers of all the base contracts.
    /// @notice GelatoCore's initializer function (constructor for upgradeable contracts)
    function initialize()
        public
        initializer
    {
        GelatoCoreAccounting._initialize();

used here:

github.com

gelatodigital/gelato/blob/c205a6a45118a90106bb1dda4b0d5339b2f247ba/contracts/gelato_core/GelatoCore.sol#L123


    onlyRegisteredExecutors(_selectedExecutor)
    nonReentrant
{
    // ______ Authenticate msg.sender is proxied user or a proxy _______
    address userProxy;
    if (_isUser(msg.sender)) userProxy = userToProxy[msg.sender];
    else if (_isUserProxy(msg.sender)) userProxy = msg.sender;
    else revert("GelatoCore.mintExecutionClaim: msg.sender is not proxied");
    // =============
    // ______ Charge Minting Deposit _______________________________________
    uint256 actionGasStipend = IGelatoAction(_action).getActionGasStipend();
    {
        uint256 executionMinGas = _getMinExecutionGasRequirement(actionGasStipend);
        uint256 mintingDepositPayable
            = executionMinGas.mul(executorPrice[_selectedExecutor]);
        require(msg.value == mintingDepositPayable,
            "GelatoCore.mintExecutionClaim: msg.value failed"
        );
    }
    // =============
    // ______ Mint new executionClaim ______________________________________

abcoathup · November 20, 2019, 8:43am

Hi @gitpusha,

Thank you for this.
That looks like a potential cause. I can try to reproduce now.

gitpusha · November 20, 2019, 11:21am

Hi @abcoathup, I solved it.

Somehow the oz compile did not generate a compile warning for the fact that the import statement was invalid here https://github.com/gelatodigital/gelato/blob/c205a6a45118a90106bb1dda4b0d5339b2f247ba/contracts/gelato_core/GelatoCoreAccounting.sol#L3

it should have been
import '../interfaces/triggers_actions_interfaces/IGelatoAction.sol';
not
import './interfaces/triggers_actions_interfaces/IGelatoAction.sol';

Now that I have changed it, the compiler generates the correct builds.

Topic		Replies	Views
Error while compiling with oz compile SDK	3	1160	September 23, 2019
Oz compile fails with spawnSync /bin/sh ENOBUFS SDK	5	3026	June 11, 2020
Error: Unexpected string in JSON at position 23357 SDK	2	2237	October 28, 2019
`oz compile` typechain artifact generation overwrites artifacts SDK	1	838	April 24, 2020
@openzeppelin/cli CLI bug that wont let me input name on oz call SDK	3	748	November 14, 2019

Unexpected token in JSON - oz compile -> oz create build bug

Related topics