Number can only safely store up to 53 bits

Jshanks21 · March 9, 2020, 10:27pm

Sure thing, you mean creating a separate post in the Showcase topic or a different topic?

I'll also pushed the code to my GitHub. The test is here:

Jshanks21/ICO/blob/master/test/MyCrowdsale.test.js

const { accounts, contract } = require('@openzeppelin/test-environment');

const {
	BN,
	time,
	ether,
	balance,
	expectRevert
} = require('@openzeppelin/test-helpers');

const { expect } = require('chai');
const chai = require('chai');
chai.use(require('chai-as-promised'))
	.should();

const OZToken = contract.fromArtifact("OZToken");
const MyCrowdsale = contract.fromArtifact("MyCrowdsale");
 
describe('MyCrowdsale', function () {
	// Prevents 2000ms timeout error

This file has been truncated. show original

And the contract is here:

github.com

Jshanks21/ICO/blob/master/contracts/MyCrowdsale.sol

pragma solidity ^0.5.0;

import "@openzeppelin/contracts/token/ERC20/ERC20Mintable.sol";
import "@openzeppelin/contracts/token/ERC20/ERC20Pausable.sol";
import "@openzeppelin/contracts/ownership/Ownable.sol";
import "@openzeppelin/contracts/crowdsale/emission/MintedCrowdsale.sol";
import "@openzeppelin/contracts/crowdsale/validation/CappedCrowdsale.sol";
import "@openzeppelin/contracts/crowdsale/validation/TimedCrowdsale.sol";
import "@openzeppelin/contracts/crowdsale/validation/WhitelistCrowdsale.sol";
import "@openzeppelin/contracts/crowdsale/distribution/RefundablePostDeliveryCrowdsale.sol";

contract MyCrowdsale is
    MintedCrowdsale,
    CappedCrowdsale,
    TimedCrowdsale,
    WhitelistCrowdsale,
    RefundableCrowdsale,
    Ownable
{

This file has been truncated. show original

You may also need the token contract:

github.com

Jshanks21/ICO/blob/master/contracts/OZToken.sol

pragma solidity >=0.4.21 <0.7.0;

import "@openzeppelin/contracts/token/ERC20/ERC20Mintable.sol";
import "@openzeppelin/contracts/token/ERC20/ERC20Detailed.sol";
import "@openzeppelin/contracts/token/ERC20/ERC20Pausable.sol";

/**
 * @title OZToken
 * @notice This token was created for use in MyCrowdsale.sol
 * @dev This is a basic ERC-20 implementation using the OpenZeppelin library for base and extended functions
 */
contract OZToken is ERC20Mintable, ERC20Pausable, ERC20Detailed {

	/**
     * @dev Sets the values for `name`, `symbol`, and `decimals`. All three of
     * these values are immutable: they can only be set once during
     * construction. See {ERC20Detailed-construcotor}.
     */
	constructor(string memory _name, string memory _symbol, uint8 _decimals, uint256 _initialSupply)
		ERC20Detailed(_name, _symbol, _decimals)

This file has been truncated. show original

The whole test run fails before running any of the listed tests. It reads the describe('MyCrowdsale', function () { ... } and fails before completing the beforeEach hook.

abcoathup · March 10, 2020, 3:59pm

Hi @Jshanks21,

The issue is caused by the addition:

this.openingTime:     1584460088
this.openingTime + 1: 15844600881

The OpenZeppelin Contract tests are great to see how to use OpenZeppelin Test Helpers

github.com

OpenZeppelin/openzeppelin-contracts/blob/v2.5.0/test/crowdsale/TimedCrowdsale.test.js#L23


const rate = new BN(1);
const value = ether('42');
const tokenSupply = new BN('10').pow(new BN('22'));


before(async function () {
  // Advance to the next block to correctly read time in the solidity "now" function interpreted by ganache
  await time.advanceBlock();
});


beforeEach(async function () {
  this.openingTime = (await time.latest()).add(time.duration.weeks(1));
  this.closingTime = this.openingTime.add(time.duration.weeks(1));
  this.afterClosingTime = this.closingTime.add(time.duration.seconds(1));
  this.token = await SimpleToken.new();
});


it('reverts if the opening time is in the past', async function () {
  await expectRevert(TimedCrowdsaleImpl.new(
    (await time.latest()).sub(time.duration.days(1)), this.closingTime, rate, wallet, this.token.address
  ), 'TimedCrowdsale: opening time is before current time');
});

You could make the following change to your tests:

    this.openingTime = (await time.latest()).add(time.duration.weeks(1));
    this.closingTime = this.openingTime.add(time.duration.weeks(1));

Jshanks21 · March 10, 2020, 5:33pm

Thank you @abcoathup! The error makes sense when reading the test above. I’ll try running it this way when I have time today and let you know if it resolves the issue.

Jshanks21 · March 10, 2020, 6:51pm

I just tested it after updating it and the previous error was resolved. I see how concatenating these values could cause it to exceed the acceptable limit.

I’ll definitely be reading through these tests more closely to make mine more effective. Thanks again @abcoathup!

Jshanks21 · March 10, 2020, 7:28pm

I have one more question about some of the math in these tests: The syntax for .add .sub and .pow are very similar to the math functions from the SafeMath library.

Are these being called from the test-helpers file or are they already integrated as part of the test-environment? As far as I know, these aren’t native to JS so I’m just curious where we pulled them from, then I can take a closer look.

abcoathup · March 10, 2020, 7:47pm

Hi @Jshanks21,

OpenZeppelin Test Helpers uses BN.js.

BN.js has arithmetic functions add, sub, mul etc.

We can see a BN object being returned from latest in Test Helpers.

github.com

OpenZeppelin/openzeppelin-test-helpers/blob/master/src/time.js#L37


${colors.white.bgBlack('@openzeppelin/test-helpers')} ${colors.black.bgYellow('WARN')} advanceBlockTo: Advancing too ` +
      'many blocks is causing this test to be slow.');
    }
    await advanceBlock();
  }
}


// Returns the time of the last mined block in seconds
async function latest () {
  const block = await web3.eth.getBlock('latest');
  return new BN(block.timestamp);
}


async function latestBlock () {
  const block = await web3.eth.getBlock('latest');
  return new BN(block.number);
}


// Increases ganache time by the passed duration in seconds
async function increase (duration) {
  if (!BN.isBN(duration)) {

Topic		Replies	Views
Error in test: Number can only safely store up to 53 bits Contracts	5	3525	September 9, 2022
My Coding Journey: Beginner to Pro Showcase coding-journey	117	24497	December 18, 2023
Error in test: Number can only safely store up to 53 bits even with BN.js Support	2	1229	March 30, 2021
Help wanted with rate testing for crowdsale Contracts	2	1255	July 30, 2019
TimedCrowdsale Test not working Contracts erc20	6	973	April 6, 2021

Number can only safely store up to 53 bits

Related topics