Implementation of sellable NFT

abcoathup · January 25, 2021, 1:51am

Welcome to the community

I am a Community Manager and not a Security Researcher. I would recommend appropriate testing and auditing.

Thoughts from my perspective as a Community Manager:

My preference is to only include functionality in a token that is required for the life of the token.
I would separate the purchase functionality from the token, as you are only selling tokens up until a fixed cap.

The price of the token is fixed, which may be an issue depending on the expected life of the sale. The fiat value of 0.2 Ether could drastically change (up or down) over a longer period of time.

You are currently setting a token URI when you mint. This increases the cost of minting, when all you appear to be doing is using a URI combining the baseURI, the token ID and metadata.json, e.g. https://baseURI.com/token/1/metadata.json. I would look at changing the naming scheme on your server to reduce this cost. See the following example:

github.com

OpenZeppelin/openzeppelin-contracts/blob/6be5ffe54fc8982b7c1d0f45d4cb7bbd313107cd/contracts/presets/ERC721PresetMinterPauserAutoId.sol#L62


      
           * @dev Creates a new token for `to`. Its token ID will be automatically
           * assigned (and available on the emitted {IERC721-Transfer} event), and the token
           * URI autogenerated based on the base URI passed at construction.
           *
           * See {ERC721-_mint}.
           *
           * Requirements:
           *
           * - the caller must have the `MINTER_ROLE`.
           */
          function mint(address to) public virtual {
              require(hasRole(MINTER_ROLE, _msgSender()), "ERC721PresetMinterPauserAutoId: must have minter role to mint");
          
              // We cannot just use balanceOf to create the new tokenId because tokens
              // can be burned (destroyed), so we need a separate counter.
              _mint(to, _tokenIdTracker.current());
              _tokenIdTracker.increment();
          }
          
          /**
           * @dev Pauses all token transfers.

Also look at the example in: Create an NFT and deploy to a public testnet, using Truffle

Topic		Replies	Views
Simple ERC721 Contract Smart Contracts erc721	9	1119	March 7, 2022
Creating an ERC721 Simple contract to mint NFTs Smart Contracts erc721 , nft	3	2801	March 14, 2022
Why does openzeppelin ERC721 remove payable Contracts erc20 , erc721	1	699	June 14, 2022
How can I ensure that any user can buy NFT's that the owner sells and keep royalties fixed? Smart Contracts	7	480	June 26, 2023
Making an high-quality NFT Smart Contract Contracts erc721 , solidity , openzeppelin-contracts , nft , etherscan-verify	1	688	July 31, 2023

Implementation of sellable NFT

Related topics