Hardhat-deploy plugin missing unsafeAllowLinkedLibraries flag or another error?

intoverq · October 7, 2021, 11:53pm

Before using unsafeAllowLinkedLibraries hardhat-deploy my deploy script looked like this:

require("@nomiclabs/hardhat-web3");
const { HardhatRuntimeEnvironment } = require('hardhat/types');

async function main() {
  const accounts = await ethers.getSigners()

  const LibExchangeAuctionFactory = await ethers.getContractFactory("LibExchangeAuction");
  const libExchangeAuction = await LibExchangeAuctionFactory.deploy();
  const ExchangeV2 = await ethers.getContractFactory("ExchangeV2", {
    libraries: {
      LibExchangeAuction: libExchangeAuction.address
    }
  });
  const TransferProxy = await ethers.getContractFactory('TransferProxy');
  const ERC20TransferProxy = await ethers.getContractFactory('ERC20TransferProxy');

  //deploy and initialize TransferProxy
  transferProxyDeployed = await TransferProxy.deploy();
  await transferProxyDeployed.__TransferProxy_init();

  //deploy and initialize ERC20TransferProxy
  erc20TransferProxyDeployed = await ERC20TransferProxy.deploy();
  await erc20TransferProxyDeployed.__ERC20TransferProxy_init();

  const transferProxy = transferProxyDeployed.address
  const erc20TransferProxy = erc20TransferProxyDeployed.address

  const exchangeFeeWallet = accounts[0].address
  const adminRecoveryAddress = accounts[0].address
  const feesBP = 200

  const instance = await upgrades.deployProxy(
    ExchangeV2,
    [transferProxy, erc20TransferProxy, feesBP, exchangeFeeWallet, adminRecoveryAddress],
    { initializer: '__ExchangeV2_init', unsafeAllowLinkedLibraries: true }
  );

  //add ExchangeV2 address to the the allowed operators of transferProxy & erc20TransferProxy
  await transferProxyDeployed.addOperator(instance.address)
  await erc20TransferProxyDeployed.addOperator(instance.address)

  console.log('ExchangeV2 Deployed', instance.address);
  console.log('transferProxy: ', transferProxy)
  console.log('erc20TransferProxy: ', erc20TransferProxy)
  console.log('exchangeFeeWallet: ', exchangeFeeWallet)
  console.log('adminRecoveryAddress: ', adminRecoveryAddress)
  console.log('libExchangeAuction deployed: ', libExchangeAuction.address);
  console.log('fees value: ', feesBP / 100 + '%')
}

main()
  .then(() => process.exit(0))
  .catch(error => {
    console.error(error);
    process.exit(1);
  });

and contracts were deploying fine.

Now using hardhat-deploy (for several reasons) and getting a cryptic error about my new deploy script:


import {HardhatRuntimeEnvironment} from 'hardhat/types';
import {DeployFunction} from 'hardhat-deploy/types';

const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
  const {deployments, getNamedAccounts} = hre;
  const {deploy} = deployments;

  const {deployer} = await getNamedAccounts();
  
  
  const TransferProxy = await hre.deployments.get('TransferProxy');
  const ERC20TransferProxy = await hre.deployments.get('ERC20TransferProxy');
  const feesBP = 200

  await deploy('ExchangeV2', {
    from: deployer,
    proxy: {
      owner: deployer,
      proxyContract: 'OpenZeppelinTransparentProxy',
      execute: {
        init: {
          methodName: '__ExchangeV2_init',
          args: [TransferProxy.address, ERC20TransferProxy.address, feesBP, deployer, deployer],
        },
      },
    },
    log: true,
  });
  console.log('transferProxy: ', TransferProxy.address)
  console.log('erc20TransferProxy: ', ERC20TransferProxy.address)
  console.log('exchangeFeeWallet: ', deployer)
  console.log('adminRecoveryAddress: ', deployer)
  console.log('fees value: ', feesBP / 100 + '%')
};
export default func;
func.tags = ['ExchangeV2'];
module.exports.dependencies = ['TransferProxy', 'ERC20TransferProxy']; // this ensure the Token script above is executed first, so `deployments.get('Token')` succeeds

Double Checked the arguments and try to remove parts of the proxy part:

 proxy: {
      owner: deployer,
      proxyContract: 'OpenZeppelinTransparentProxy',
      execute: {
        init: {
          methodName: '__ExchangeV2_init',
          args: [TransferProxy.address, ERC20TransferProxy.address, feesBP, deployer, deployer],
        },
      },

still getting the same error.

Error

Nothing to compile
No need to generate any newer typings.
deploying "TransferProxy" (tx: 0x7742d91aea442e05ad5124fb7e2d022b99750870fb9e6f3851c07de2aecb7c10)...: deployed at 0x5FbDB2315678afecb367f032d93F642f64180aa3 with 580020 gas
executing TransferProxy.__TransferProxy_init (tx: 0xe4a4a0ab3f37a5a897b33ba6725b64dd7c69fff6d7d56fc27d84eb43c8a56477) ...: performed with 68699 gas
deploying "ERC20TransferProxy" (tx: 0x000e66d2fb67a6dd8e2f2b5de9dddddbaaa1fd7dba0f45396bc578556e489350)...: deployed at 0x9fE46736679d2D9a65F0992F2272dE9f3c7fa6e0 with 508719 gas
executing ERC20TransferProxy.__ERC20TransferProxy_init (tx: 0x302340130838bd8e0ca5ad4d8c902a291322335f6fd5de5abef9553dea797c73) ...: performed with 68721 gas
deploying "DefaultProxyAdmin" (tx: 0x94827f0fbfd094ba4bafc34efda34a27de24c55ed897d2df0a54d90dbecd6157)...: deployed at 0xDc64a140Aa3E981100a9becA4E685f962f0cF6C9 with 671461 gas
An unexpected error occurred:

Error: ERROR processing /Users/selimerunkut/dev_freelance/GhostMarketContractAvalancheExchange_wighawag/deploy/003_deploy_auction.ts:
Error: invalid bytecode (argument="bytecode", value="0x608060405234801561001057600080fd5b50615ea380620000216000396000f3fe608060405
...VERY_LONG_BYTE_CODE...
21220e386586237d2001616b2acb69feee8164e5579f4864e65d2229a760d0dfc38f464736f6c63430008040033", code=INVALID_ARGUMENT, version=contracts/5.4.1)
    at Logger.makeError (/Users/selimerunkut/dev_freelance/GhostMarketContractAvalancheExchange_wighawag/node_modules/@ethersproject/logger/src.ts/index.ts:225:28)
    at Logger.throwError (/Users/selimerunkut/dev_freelance/GhostMarketContractAvalancheExchange_wighawag/node_modules/@ethersproject/logger/src.ts/index.ts:237:20)
    at Logger.throwArgumentError (/Users/selimerunkut/dev_freelance/GhostMarketContractAvalancheExchange_wighawag/node_modules/@ethersproject/logger/src.ts/index.ts:241:21)
    at new ContractFactory (/Users/selimerunkut/dev_freelance/GhostMarketContractAvalancheExchange_wighawag/node_modules/@ethersproject/contracts/src.ts/index.ts:1136:20)
    at _deploy (/Users/selimerunkut/dev_freelance/GhostMarketContractAvalancheExchange_wighawag/node_modules/hardhat-deploy/src/helpers.ts:530:21)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at runNextTicks (internal/process/task_queues.js:64:3)
    at listOnTimeout (internal/timers.js:526:9)
    at processTimers (internal/timers.js:500:7)
    at async _deployOne (/Users/selimerunkut/dev_freelance/GhostMarketContractAvalancheExchange_wighawag/node_modules/hardhat-deploy/src/helpers.ts:895:16)
    at DeploymentsManager.executeDeployScripts (/Users/selimerunkut/dev_freelance/GhostMarketContractAvalancheExchange_wighawag/node_modules/hardhat-deploy/src/DeploymentsManager.ts:1108:19)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at runNextTicks (internal/process/task_queues.js:64:3)
    at listOnTimeout (internal/timers.js:526:9)
    at processTimers (internal/timers.js:500:7)
    at async DeploymentsManager.runDeploy (/Users/selimerunkut/dev_freelance/GhostMarketContractAvalancheExchange_wighawag/node_modules/hardhat-deploy/src/DeploymentsManager.ts:938:5)
    at async Environment._runTaskDefinition (/Users/selimerunkut/dev_freelance/GhostMarketContractAvalancheExchange_wighawag/node_modules/hardhat/src/internal/core/runtime-environment.ts:217:14)
    at async Environment.run (/Users/selimerunkut/dev_freelance/GhostMarketContractAvalancheExchange_wighawag/node_modules/hardhat/src/internal/core/runtime-environment.ts:129:14)
    at async SimpleTaskDefinition.action (/Users/selimerunkut/dev_freelance/GhostMarketContractAvalancheExchange_wighawag/node_modules/hardhat-deploy/src/index.ts:546:32)
    at async Environment._runTaskDefinition (/Users/selimerunkut/dev_freelance/GhostMarketContractAvalancheExchange_wighawag/node_modules/hardhat/src/internal/core/runtime-environment.ts:217:14)
error Command failed with exit code 1.

Code to reproduce

Environment

see here: https://github.com/selimerunkut/find_bugs/blob/main/package.json

intoverq · October 8, 2021, 5:00pm

Changing the library function from public to internal, solved the issue.

More details here:

github.com/ethereum/solidity

Compiles but Error: invalid bytecode when trying to deploy

opened 09:01AM - 21 Feb 21 UTC

closed 10:52AM - 22 Feb 21 UTC

gitpusha

## Description I have one specific function which compiles fine but when I tr…y to deploy the contract which it is on with `hardhat-deploy` I get an `Error: invalid bytecode` . ## Environment - Compiler version: 0.8.0 - Framework/IDE: hardhat - EVM execution environment / backend / blockchain client: hardhat network - Operating system: macOS ## Steps to Reproduce The contract is not public yet but I am trying to distill down the part that is causing the bug here. 1. Compile `ExecFacet` contract with `hardhat compile` using `0.8.0` (solc-js) 2. No compilation error. 3. Try to deploy the `ExecFacet` contract with `hardhat-deploy` 4. Get `Error: invalid bytecode` ![image](https://user-images.githubusercontent.com/36712489/108620046-7fb54780-7429-11eb-9183-36f04c69e83a.png) ```solidity pragma solidity 0.8.0; library EnumerableSet { // To implement this library for multiple types with as little code // repetition as possible, we write it in terms of a generic Set type with // bytes32 values. // The Set implementation uses private functions, and user-facing // implementations (such as AddressSet) are just wrappers around the // underlying Set. // This means that we can only create new EnumerableSets for types that fit // in bytes32. struct Set { // Storage of set values bytes32[] _values; // Position of the value in the `values` array, plus 1 because index 0 // means a value is not in the set. mapping(bytes32 => uint256) _indexes; } /** * @dev Add a value to a set. O(1). * * Returns true if the value was added to the set, that is if it was not * already present. */ function _add(Set storage set, bytes32 value) private returns (bool) { if (!_contains(set, value)) { set._values.push(value); // The value is stored at length-1, but we add 1 to all indexes // and use 0 as a sentinel value set._indexes[value] = set._values.length; return true; } else { return false; } } /** * @dev Removes a value from a set. O(1). * * Returns true if the value was removed from the set, that is if it was * present. */ function _remove(Set storage set, bytes32 value) private returns (bool) { // We read and store the value's index to prevent multiple reads from the same storage slot uint256 valueIndex = set._indexes[value]; if (valueIndex != 0) { // Equivalent to contains(set, value) // To delete an element from the _values array in O(1), we swap the element to delete with the last one in // the array, and then remove the last element (sometimes called as 'swap and pop'). // This modifies the order of the array, as noted in {at}. uint256 toDeleteIndex = valueIndex - 1; uint256 lastIndex = set._values.length - 1; // When the value to delete is the last one, the swap operation is unnecessary. However, since this occurs // so rarely, we still do the swap anyway to avoid the gas cost of adding an 'if' statement. bytes32 lastvalue = set._values[lastIndex]; // Move the last value to the index where the value to delete is set._values[toDeleteIndex] = lastvalue; // Update the index for the moved value set._indexes[lastvalue] = toDeleteIndex + 1; // All indexes are 1-based // Delete the slot where the moved value was stored set._values.pop(); // Delete the index for the deleted slot delete set._indexes[value]; return true; } else { return false; } } /** * @dev Returns true if the value is in the set. O(1). */ function _contains(Set storage set, bytes32 value) private view returns (bool) { return set._indexes[value] != 0; } /** * @dev Returns the number of values on the set. O(1). */ function _length(Set storage set) private view returns (uint256) { return set._values.length; } /** * @dev Returns the value stored at position `index` in the set. O(1). * * Note that there are no guarantees on the ordering of values inside the * array, and it may change when more values are added or removed. * * Requirements: * * - `index` must be strictly less than {length}. */ function _at(Set storage set, uint256 index) private view returns (bytes32) { require( set._values.length > index, "EnumerableSet: index out of bounds" ); return set._values[index]; } // Bytes32Set struct Bytes32Set { Set _inner; } /** * @dev Add a value to a set. O(1). * * Returns true if the value was added to the set, that is if it was not * already present. */ function add(Bytes32Set storage set, bytes32 value) internal returns (bool) { return _add(set._inner, value); } /** * @dev Removes a value from a set. O(1). * * Returns true if the value was removed from the set, that is if it was * present. */ function remove(Bytes32Set storage set, bytes32 value) internal returns (bool) { return _remove(set._inner, value); } /** * @dev Returns true if the value is in the set. O(1). */ function contains(Bytes32Set storage set, bytes32 value) internal view returns (bool) { return _contains(set._inner, value); } /** * @dev Returns the number of values in the set. O(1). */ function length(Bytes32Set storage set) internal view returns (uint256) { return _length(set._inner); } /** * @dev Returns the value stored at position `index` in the set. O(1). * * Note that there are no guarantees on the ordering of values inside the * array, and it may change when more values are added or removed. * * Requirements: * * - `index` must be strictly less than {length}. */ function at(Bytes32Set storage set, uint256 index) internal view returns (bytes32) { return _at(set._inner, index); } // AddressSet struct AddressSet { Set _inner; } /** * @dev Add a value to a set. O(1). * * Returns true if the value was added to the set, that is if it was not * already present. */ function add(AddressSet storage set, address value) internal returns (bool) { return _add(set._inner, bytes32(uint256(uint160(value)))); } /** * @dev Removes a value from a set. O(1). * * Returns true if the value was removed from the set, that is if it was * present. */ function remove(AddressSet storage set, address value) internal returns (bool) { return _remove(set._inner, bytes32(uint256(uint160(value)))); } /** * @dev Returns true if the value is in the set. O(1). */ function contains(AddressSet storage set, address value) internal view returns (bool) { return _contains(set._inner, bytes32(uint256(uint160(value)))); } /** * @dev Returns the number of values in the set. O(1). */ function length(AddressSet storage set) internal view returns (uint256) { return _length(set._inner); } /** * @dev Returns the value stored at position `index` in the set. O(1). * * Note that there are no guarantees on the ordering of values inside the * array, and it may change when more values are added or removed. * * Requirements: * * - `index` must be strictly less than {length}. */ function at(AddressSet storage set, uint256 index) internal view returns (address) { return address(uint160(uint256(_at(set._inner, index)))); } // UintSet struct UintSet { Set _inner; } /** * @dev Add a value to a set. O(1). * * Returns true if the value was added to the set, that is if it was not * already present. */ function add(UintSet storage set, uint256 value) internal returns (bool) { return _add(set._inner, bytes32(value)); } /** * @dev Removes a value from a set. O(1). * * Returns true if the value was removed from the set, that is if it was * present. */ function remove(UintSet storage set, uint256 value) internal returns (bool) { return _remove(set._inner, bytes32(value)); } /** * @dev Returns true if the value is in the set. O(1). */ function contains(UintSet storage set, uint256 value) internal view returns (bool) { return _contains(set._inner, bytes32(value)); } /** * @dev Returns the number of values on the set. O(1). */ function length(UintSet storage set) internal view returns (uint256) { return _length(set._inner); } /** * @dev Returns the value stored at position `index` in the set. O(1). * * Note that there are no guarantees on the ordering of values inside the * array, and it may change when more values are added or removed. * * Requirements: * * - `index` must be strictly less than {length}. */ function at(UintSet storage set, uint256 index) internal view returns (uint256) { return uint256(_at(set._inner, index)); } } library LibService { using EnumerableSet for EnumerableSet.AddressSet; using LibExecutor for address; using LibService for address; bytes32 private constant _SERVICE_STORAGE = keccak256("gelato.diamond.service.storage"); struct ServiceStorage { EnumerableSet.AddressSet services; mapping(address => EnumerableSet.AddressSet) servicesByExecutor; } function isListed(address _service) internal view returns (bool) { return serviceStorage().services.contains(_service); } function isAcceptedByExecutor(address _service, address _executor) internal view returns (bool) { return serviceStorage().servicesByExecutor[_executor].contains(_service); } function serviceStorage() internal pure returns (ServiceStorage storage ss) { bytes32 position = _SERVICE_STORAGE; assembly { ss.slot := position } } } library LibExecutor { using LibService for address; function canExec(address _service, address _executor) public view returns (bool) { return _service.isListed() && _service.isAcceptedByExecutor(_executor); } } contract ExecFacet { using LibExecutor for address; using LibService for address; function canExec(address _service, address _executor) public view returns (bool) { return _service.canExec(_executor); } } ``` Now the interesting bit is that it compiles fine but doesnt deploy. However, when I get rid of `LibExecutor` and change the `canExec` code to this, it compiles and deploys. The `invalid bytecode` error is gone. ```solidity contract ExecFacet { using LibService for address; function canExec(address _service, address _executor) public view returns (bool) { return _service.isListed() && _service.isAcceptedByExecutor(_executor); } } ``` Tagging @wighawag who built `hardhat-deploy` .

frangio · October 14, 2021, 8:40pm

Note that hardhat-deploy is not associated to OpenZeppelin, so we can't provide any guarantees and will generally not be able to provide support.

intoverq · October 15, 2021, 8:34am

Hello Frangio,

I think, created this topic under the wrong category, should be probably "general"

this issue is solved; was more a smart contract related issue then hardhat-deploy, maybe it helps others who have the same bug to solve it faster then I did.

Best

PatrickAlphaC · January 26, 2022, 2:55pm

Wild that this is the answer. Nice find.

Topic		Replies	Views
Oz/hardhat-upgrades unsafeAllow: "external-library-linking" error Upgrades	2	532	October 15, 2023
DeployProxy with HardHat on Goerli Network Error Upgrades proxies , etherscan-verify	2	985	October 4, 2022
Hardhat deploy script Review Wanted	5	1551	August 26, 2021
Unable to link the following libraries: contracts/IterableMapping.sol:IterableMapping Developer Wanted erc20 , hardhat , bep20 , etherscan-verify	1	2091	December 8, 2021
Can't deploy a new implementation contract or a new proxy! Upgrades proxies , etherscan-verify	11	3152	November 1, 2022

Hardhat-deploy plugin missing unsafeAllowLinkedLibraries flag or another error?

Error

Code to reproduce

Environment

Related Topics