Setting AccessControl(Upgradeable)._grantRole as internal is confusing - better use private

[vino333]

Hey all,

In AccessControl and AccessControlUpgradeable _grantRole is internal
This practically makes _setupRole redundant, since _setupRole just calls _grantRole, and both have the same visibility level.

The only advantage _setupRole have is that its name implies that it doesn't perform any checks before assigning the role, hence good for initialization.

So, I believe that making _grantRole private will add security.

Any Thoughts?

[frangio]

_setupRole was deprecated in favor of _grantRole and it will be removed in a future version.

OpenZeppelin/openzeppelin-contracts/blob/14f98dbb581a5365ce3f0c50bd850e499c554f72/contracts/access/AccessControl.sol#L203

[vino333]

Ahh, I didn't notice that, thank you for your response!