Sending tax problem

Smart Contracts
,
1

I DEPLOYED THIS TOKEN YESTERDAY ON BSC MAINNET
I COULDNT UNDERSTAND WHERE ALL THE TAX WAS GOING AND IT KEPT TAKING THE TAX AND NOTHING CAME TO MY TAX WALLET, I ADDED JUST 16$ WORTH OF LIQUIDITY, HERE IS THE TOKEN ON BSCAN https://bscscan.com/token/0x273C36C21Be2049CE275003D46c2ee7Aa15f6bE9

HERE IS THE CODE

/**
*Submitted for verification at Etherscan.io on 2023-06-21
*/

pragma solidity ^0.8.18;
// SPDX-License-Identifier: MIT

interface IERC20 {
function totalSupply() external view returns (uint256);
function balanceOf(address account) external view returns (uint256);
function transfer(address recipient, uint256 amount) external returns (bool);
function allowance(address owner, address spender) external view returns (uint256);
function approve(address spender, uint256 amount) external returns (bool);
function transferFrom(address sender, address recipient, uint256 amount) external returns (bool);
event Transfer(address indexed from, address indexed to, uint256 value);
event Approval(address indexed owner, address indexed spender, uint256 value);
}
library SafeMath {
function add(uint256 a, uint256 b) internal pure returns (uint256) {
return a + b;
}
function sub(uint256 a, uint256 b) internal pure returns (uint256) {
return a - b;
}
function mul(uint256 a, uint256 b) internal pure returns (uint256) {
return a * b;
}
function div(uint256 a, uint256 b) internal pure returns (uint256) {
return a / b;
}
function sub(uint256 a, uint256 b, string memory errorMessage) internal pure returns (uint256) {
unchecked {
require(b <= a, errorMessage);
return a - b;
}
}
function div(uint256 a, uint256 b, string memory errorMessage) internal pure returns (uint256) {
unchecked {
require(b > 0, errorMessage);
return a / b;
}
}
}
abstract contract Context {
function _msgSender() internal view virtual returns (address) {
return msg.sender;
}
function _msgData() internal view virtual returns (bytes calldata) {
this;
return msg.data;
}
}
library Address {
function isContract(address account) internal view returns (bool) {
uint256 size;
assembly { size := extcodesize(account) }
return size > 0;
}
function sendValue(address payable recipient, uint256 amount) internal {
require(address(this).balance >= amount, "Address: insufficient balance");
(bool success, ) = recipient.call{ value: amount }("");
require(success, "Address: unable to send value, recipient may have reverted");
}
function functionCall(address target, bytes memory data) internal returns (bytes memory) {
return functionCall(target, data, "Address: low-level call failed");
}
function functionCall(address target, bytes memory data, string memory errorMessage) internal returns (bytes memory) {
return functionCallWithValue(target, data, 0, errorMessage);
}
function functionCallWithValue(address target, bytes memory data, uint256 value) internal returns (bytes memory) {
return functionCallWithValue(target, data, value, "Address: low-level call with value failed");
}
function functionCallWithValue(address target, bytes memory data, uint256 value, string memory errorMessage) internal returns (bytes memory) {
require(address(this).balance >= value, "Address: insufficient balance for call");
require(isContract(target), "Address: call to non-contract");
(bool success, bytes memory returndata) = target.call{ value: value }(data);
return _verifyCallResult(success, returndata, errorMessage);
}
function functionStaticCall(address target, bytes memory data) internal view returns (bytes memory) {
return functionStaticCall(target, data, "Address: low-level static call failed");
}
function functionStaticCall(address target, bytes memory data, string memory errorMessage) internal view returns (bytes memory) {
require(isContract(target), "Address: static call to non-contract");
(bool success, bytes memory returndata) = target.staticcall(data);
return _verifyCallResult(success, returndata, errorMessage);
}
function functionDelegateCall(address target, bytes memory data) internal returns (bytes memory) {
return functionDelegateCall(target, data, "Address: low-level delegate call failed");
}
function functionDelegateCall(address target, bytes memory data, string memory errorMessage) internal returns (bytes memory) {
require(isContract(target), "Address: delegate call to non-contract");
(bool success, bytes memory returndata) = target.delegatecall(data);
return _verifyCallResult(success, returndata, errorMessage);
}
function _verifyCallResult(bool success, bytes memory returndata, string memory errorMessage) private pure returns(bytes memory) {
if (success) {
return returndata;
} else {
if (returndata.length > 0) {
assembly {
let returndata_size := mload(returndata)
revert(add(32, returndata), returndata_size)
}
} else {
revert(errorMessage);
}
}
}
}
interface IUniswapV2Factory {
event PairCreated(address indexed token0, address indexed token1, address pair, uint);
function feeTo() external view returns (address);
function feeToSetter() external view returns (address);
function getPair(address tokenA, address tokenB) external view returns (address pair);
function allPairs(uint) external view returns (address pair);
function allPairsLength() external view returns (uint);
function createPair(address tokenA, address tokenB) external returns (address pair);
function setFeeTo(address) external;
function setFeeToSetter(address) external;
}
interface IUniswapV2Pair {
event Approval(address indexed owner, address indexed spender, uint value);
event Transfer(address indexed from, address indexed to, uint value);
function name() external pure returns (string memory);
function symbol() external pure returns (string memory);
function decimals() external pure returns (uint8);
function totalSupply() external view returns (uint);
function balanceOf(address owner) external view returns (uint);
function allowance(address owner, address spender) external view returns (uint);
function approve(address spender, uint value) external returns (bool);
function transfer(address to, uint value) external returns (bool);
function transferFrom(address from, address to, uint value) external returns (bool);
function DOMAIN_SEPARATOR() external view returns (bytes32);
function PERMIT_TYPEHASH() external pure returns (bytes32);
function nonces(address owner) external view returns (uint);
function permit(address owner, address spender, uint value, uint deadline, uint8 v, bytes32 r, bytes32 s) external;
event Burn(address indexed sender, uint amount0, uint amount1, address indexed to);
event Swap(
address indexed sender,
uint amount0In,
uint amount1In,
uint amount0Out,
uint amount1Out,
address indexed to
);
event Sync(uint112 reserve0, uint112 reserve1);
function MINIMUM_LIQUIDITY() external pure returns (uint);
function factory() external view returns (address);
function token0() external view returns (address);
function token1() external view returns (address);
function getReserves() external view returns (uint112 reserve0, uint112 reserve1, uint32 blockTimestampLast);
function price0CumulativeLast() external view returns (uint);
function price1CumulativeLast() external view returns (uint);
function kLast() external view returns (uint);
function burn(address to) external returns (uint amount0, uint amount1);
function swap(uint amount0Out, uint amount1Out, address to, bytes calldata data) external;
function skim(address to) external;
function sync() external;
function initialize(address, address) external;
}
interface IUniswapV2Router01 {
function factory() external pure returns (address);
function WETH() external pure returns (address);
function addLiquidity(
address tokenA,
address tokenB,
uint amountADesired,
uint amountBDesired,
uint amountAMin,
uint amountBMin,
address to,
uint deadline
) external returns (uint amountA, uint amountB, uint liquidity);
function addLiquidityETH(
address token,
uint amountTokenDesired,
uint amountTokenMin,
uint amountETHMin,
address to,
uint deadline
) external payable returns (uint amountToken, uint amountETH, uint liquidity);
function removeLiquidity(
address tokenA,
address tokenB,
uint liquidity,
uint amountAMin,
uint amountBMin,
address to,
uint deadline
) external returns (uint amountA, uint amountB);
function removeLiquidityETH(
address token,
uint liquidity,
uint amountTokenMin,
uint amountETHMin,
address to,
uint deadline
) external returns (uint amountToken, uint amountETH);
function removeLiquidityWithPermit(
address tokenA,
address tokenB,
uint liquidity,
uint amountAMin,
uint amountBMin,
address to,
uint deadline,
bool approveMax, uint8 v, bytes32 r, bytes32 s
) external returns (uint amountA, uint amountB);
function removeLiquidityETHWithPermit(
address token,
uint liquidity,
uint amountTokenMin,
uint amountETHMin,
address to,
uint deadline,
bool approveMax, uint8 v, bytes32 r, bytes32 s
) external returns (uint amountToken, uint amountETH);
function swapExactTokensForTokens(
uint amountIn,
uint amountOutMin,
address calldata path,
address to,
uint deadline
) external returns (uint memory amounts);
function swapTokensForExactTokens(
uint amountOut,
uint amountInMax,
address calldata path,
address to,
uint deadline
) external returns (uint memory amounts);
function swapExactETHForTokens(uint amountOutMin, address calldata path, address to, uint deadline)
external
payable
returns (uint memory amounts);
function swapTokensForExactETH(uint amountOut, uint amountInMax, address calldata path, address to, uint deadline)
external
returns (uint memory amounts);
function swapExactTokensForETH(uint amountIn, uint amountOutMin, address calldata path, address to, uint deadline)
external
returns (uint memory amounts);
function swapETHForExactTokens(uint amountOut, address calldata path, address to, uint deadline)
external
payable
returns (uint memory amounts);
function quote(uint amountA, uint reserveA, uint reserveB) external pure returns (uint amountB);
function getAmountOut(uint amountIn, uint reserveIn, uint reserveOut) external pure returns (uint amountOut);
function getAmountIn(uint amountOut, uint reserveIn, uint reserveOut) external pure returns (uint amountIn);
function getAmountsOut(uint amountIn, address calldata path) external view returns (uint memory amounts);
function getAmountsIn(uint amountOut, address calldata path) external view returns (uint memory amounts);
}
interface IUniswapV2Router02 is IUniswapV2Router01 {
function removeLiquidityETHSupportingFeeOnTransferTokens(
address token,
uint liquidity,
uint amountTokenMin,
uint amountETHMin,
address to,
uint deadline
) external returns (uint amountETH);
function removeLiquidityETHWithPermitSupportingFeeOnTransferTokens(
address token,
uint liquidity,
uint amountTokenMin,
uint amountETHMin,
address to,
uint deadline,
bool approveMax, uint8 v, bytes32 r, bytes32 s
) external returns (uint amountETH);
function swapExactTokensForTokensSupportingFeeOnTransferTokens(
uint amountIn,
uint amountOutMin,
address calldata path,
address to,
uint deadline
) external;
function swapExactETHForTokensSupportingFeeOnTransferTokens(
uint amountOutMin,
address calldata path,
address to,
uint deadline
) external payable;
function swapExactTokensForETHSupportingFeeOnTransferTokens(
uint amountIn,
uint amountOutMin,
address calldata path,
address to,
uint deadline
) external;
}
contract Golden is Context, IERC20 {
using SafeMath for uint256;
using Address for address;
address private _owner;
event OwnershipTransferred(address indexed previousOwner, address indexed newOwner);
function owner() public view virtual returns (address) {
return _owner;
}
modifier onlyOwner() {
require(owner() == _msgSender(), "Ownable: caller is not the owner");
_;
}
function renounceOwnership() public virtual {
emit OwnershipTransferred(_owner, address(0));
_owner = address(0);
}
mapping (address => bool) private _isBot;
mapping (address => uint256) private _tOwned;
mapping (address => mapping (address => uint256)) private _allowances;
mapping (address => bool) public _isExcludedFromFee;
address payable public Wallet_Marketing = payable(0x3aa0471B5A7abA02C0F83207785E9F0De2DECD20);
address payable public Wallet_Dev = payable(0x3aa0471B5A7abA02C0F83207785E9F0De2DECD20);
address payable public constant Wallet_Burn = payable(0x000000000000000000000000000000000000dEaD);
uint256 private constant MAX = ~uint256(0);
uint8 private constant _decimals = 9;
uint256 private _tTotal =10 * 104* 10_decimals;//
string private constant _name = "Golden Boys";
string private constant _symbol = unicode"GLB";
uint8 private txCount = 0;
uint8 private swapTrigger = 10;
uint256 public _Tax_On_Buy = 10;
uint256 public _Tax_On_Sell = 10;
uint256 public Percent_Marketing = 70;
uint256 public Percent_Dev = 30;
uint256 public Percent_Burn = 0;
uint256 public Percent_AutoLP = 0;
uint256 public _maxWalletToken = _tTotal * 1 / 100;
uint256 private _previousMaxWalletToken = _maxWalletToken;
uint256 public _maxTxAmount = _tTotal * 1 / 100;
uint256 private _previousMaxTxAmount = _maxTxAmount;
IUniswapV2Router02 public uniswapV2Router;
address public uniswapV2Pair;
bool public inSwapAndLiquify;
bool public swapAndLiquifyEnabled = true;
event SwapAndLiquifyEnabledUpdated(bool true_or_false);
event SwapAndLiquify(
uint256 tokensSwapped,
uint256 ethReceived,
uint256 tokensIntoLiqudity
);
modifier lockTheSwap {
inSwapAndLiquify = true;
_;
inSwapAndLiquify = false;
}
constructor () {
_owner =0xbDE7dFa07EedAC48dc7c8721D83bBa6Ea78f5c31;
emit OwnershipTransferred(address(0), _owner);
_tOwned[owner()] = _tTotal;
IUniswapV2Router02 _uniswapV2Router = IUniswapV2Router02(0x10ED43C718714eb63d5aA57B78B54704E256024E);
uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory())
.createPair(address(this), _uniswapV2Router.WETH());
uniswapV2Router = _uniswapV2Router;
_isExcludedFromFee[owner()] = true;
_isExcludedFromFee[address(this)] = true;
_isExcludedFromFee[Wallet_Marketing] = true;
_isExcludedFromFee[Wallet_Burn] = true;
emit Transfer(address(0), owner(), _tTotal);
}

function upateFees(uint256 _taxOnBuy, uint256 _taxOnSell, uint256 _percentMarketing, uint256 _percentDev, uint256 _percentBurn, uint256 _percentAutoLp) external onlyOwner{
     _Tax_On_Buy = _taxOnBuy;
     _Tax_On_Sell = _taxOnSell;
     Percent_Marketing = _percentMarketing;
     Percent_Dev = _percentDev;
     Percent_Burn = _percentBurn;
     Percent_AutoLP = _percentAutoLp;
} 

function setAntibot(address account, bool state) external onlyOwner{
    require(_isBot[account] != state, 'Value already set');
    _isBot[account] = state;
}

function bulkAntiBot(address[] memory accounts, bool state) external onlyOwner{
    for(uint256 i = 0; i < accounts.length; i++){
        _isBot[accounts[i]] = state;
     }   
 }

 function isBot(address account) public view returns(bool){
    return _isBot[account];
}
function name() public pure returns (string memory) {
    return _name;
}
function symbol() public pure returns (string memory) {
    return _symbol;
}
function decimals() public pure returns (uint8) {
    return _decimals;
}
function totalSupply() public view override returns (uint256) {
    return _tTotal;
}
function balanceOf(address account) public view override returns (uint256) {
    return _tOwned[account];
}
function transfer(address recipient, uint256 amount) public override returns (bool) {
    _transfer(_msgSender(), recipient, amount);
    return true;
}
function allowance(address theOwner, address theSpender) public view override returns (uint256) {
    return _allowances[theOwner][theSpender];
}
function approve(address spender, uint256 amount) public override returns (bool) {
    _approve(_msgSender(), spender, amount);
    return true;
}
function transferFrom(address sender, address recipient, uint256 amount) public override returns (bool) {
    _transfer(sender, recipient, amount);
    _approve(sender, _msgSender(), _allowances[sender][_msgSender()].sub(amount, "ERC20: transfer amount exceeds allowance"));
    return true;
}
function increaseAllowance(address spender, uint256 addedValue) public virtual returns (bool) {
    _approve(_msgSender(), spender, _allowances[_msgSender()][spender].add(addedValue));
    return true;
}
function decreaseAllowance(address spender, uint256 subtractedValue) public virtual returns (bool) {
    _approve(_msgSender(), spender, _allowances[_msgSender()][spender].sub(subtractedValue, "ERC20: decreased allowance below zero"));
    return true;
}
receive() external payable {}
function _getCurrentSupply() private view returns(uint256) {
    return (_tTotal);
}
function _approve(address theOwner, address theSpender, uint256 amount) private {
    require(theOwner != address(0) && theSpender != address(0), "ERR: zero address");
    _allowances[theOwner][theSpender] = amount;
    emit Approval(theOwner, theSpender, amount);
}
function _transfer(
    address from,
    address to,
    uint256 amount
) private {
    if (to != owner() &&
        to != Wallet_Burn &&
        to != address(this) &&
        to != uniswapV2Pair &&
        from != owner()){
        uint256 heldTokens = balanceOf(to);
        require((heldTokens + amount) <= _maxWalletToken,"Over wallet limit.");}
    if (from != owner())
        require(amount <= _maxTxAmount, "Over transaction limit.");
    require(from != address(0) && to != address(0), "ERR: Using 0 address!");
    require(amount > 0, "Token value must be higher than zero."); 
    require(!_isBot[from] && !_isBot[to], "You are a bot"); 
    if(
        txCount >= swapTrigger && 
        !inSwapAndLiquify &&
        from != uniswapV2Pair &&
        swapAndLiquifyEnabled
        )
    {  
        uint256 contractTokenBalance = balanceOf(address(this));
        if(contractTokenBalance > _maxTxAmount) {contractTokenBalance = _maxTxAmount;}
        txCount = 0;
        swapAndLiquify(contractTokenBalance);
    }
    bool takeFee = true;
    bool isBuy;
    if(_isExcludedFromFee[from] || _isExcludedFromFee[to]){
        takeFee = false;
    } else {
        if(from == uniswapV2Pair){
            isBuy = true;
        }
        txCount++;
    }
    _tokenTransfer(from, to, amount, takeFee, isBuy);
}
function sendToWallet(address payable wallet, uint256 amount) private {
        wallet.transfer(amount);
    }
function swapAndLiquify(uint256 contractTokenBalance) private lockTheSwap {
        uint256 tokens_to_Burn = contractTokenBalance * Percent_Burn / 100;
        _tTotal = _tTotal - tokens_to_Burn;
        _tOwned[Wallet_Burn] = _tOwned[Wallet_Burn] + tokens_to_Burn;
        _tOwned[address(this)] = _tOwned[address(this)] - tokens_to_Burn; 
        uint256 tokens_to_M = contractTokenBalance * Percent_Marketing / 100;
        uint256 tokens_to_D = contractTokenBalance * Percent_Dev / 100;
        uint256 tokens_to_LP_Half = contractTokenBalance * Percent_AutoLP / 200;
        uint256 balanceBeforeSwap = address(this).balance;
        swapTokensForBNB(tokens_to_LP_Half + tokens_to_M + tokens_to_D);
        uint256 BNB_Total = address(this).balance - balanceBeforeSwap;
        uint256 split_M = Percent_Marketing * 100 / (Percent_AutoLP + Percent_Marketing + Percent_Dev);
        uint256 BNB_M = BNB_Total * split_M / 100;
        uint256 split_D = Percent_Dev * 100 / (Percent_AutoLP + Percent_Marketing + Percent_Dev);
        uint256 BNB_D = BNB_Total * split_D / 100;
        addLiquidity(tokens_to_LP_Half, (BNB_Total - BNB_M - BNB_D));
        emit SwapAndLiquify(tokens_to_LP_Half, (BNB_Total - BNB_M - BNB_D), tokens_to_LP_Half);
        sendToWallet(Wallet_Marketing, BNB_M);
        BNB_Total = address(this).balance;
        sendToWallet(Wallet_Dev, BNB_Total);
        }
function swapTokensForBNB(uint256 tokenAmount) private {
    address[] memory path = new address[](2);
    path[0] = address(this);
    path[1] = uniswapV2Router.WETH();
    _approve(address(this), address(uniswapV2Router), tokenAmount);
    uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(
        tokenAmount,
        0, 
        path,
        address(this),
        block.timestamp
    );
}
function addLiquidity(uint256 tokenAmount, uint256 BNBAmount) private {
    _approve(address(this), address(uniswapV2Router), tokenAmount);
    uniswapV2Router.addLiquidityETH{value: BNBAmount}(
        address(this),
        tokenAmount,
        0, 
        0,
        Wallet_Burn, 
        block.timestamp
    );
} 
function remove_Random_Tokens(address random_Token_Address, uint256 percent_of_Tokens) public returns(bool _sent){
    require(random_Token_Address != address(this), "Can not remove native token");
    uint256 totalRandom = IERC20(random_Token_Address).balanceOf(address(this));
    uint256 removeRandom = totalRandom*percent_of_Tokens/100;
    _sent = IERC20(random_Token_Address).transfer(Wallet_Dev, removeRandom);
}
function _tokenTransfer(address sender, address recipient, uint256 tAmount, bool takeFee, bool isBuy) private {
    if(!takeFee){
        _tOwned[sender] = _tOwned[sender]-tAmount;
        _tOwned[recipient] = _tOwned[recipient]+tAmount;
        emit Transfer(sender, recipient, tAmount);
        if(recipient == Wallet_Burn)
        _tTotal = _tTotal-tAmount;
        } else if (isBuy){
        uint256 buyFEE = tAmount*_Tax_On_Buy/100;
        uint256 tTransferAmount = tAmount-buyFEE;
        _tOwned[sender] = _tOwned[sender]-tAmount;
        _tOwned[recipient] = _tOwned[recipient]+tTransferAmount;
        _tOwned[address(this)] = _tOwned[address(this)]+buyFEE;  
        emit Transfer(sender, recipient, tTransferAmount);
        if(recipient == Wallet_Burn)
        _tTotal = _tTotal-tTransferAmount;
        } else {
        uint256 sellFEE = tAmount*_Tax_On_Sell/100;
        uint256 tTransferAmount = tAmount-sellFEE;
        _tOwned[sender] = _tOwned[sender]-tAmount;
        _tOwned[recipient] = _tOwned[recipient]+tTransferAmount;
        _tOwned[address(this)] = _tOwned[address(this)]+sellFEE;  
        emit Transfer(sender, recipient, tTransferAmount);
        if(recipient == Wallet_Burn)
        _tTotal = _tTotal-tTransferAmount;
        }
}

}

2

On every token transfer, the fees are registered as owned by the contract itself:

function _tokenTransfer(...) private {
    if(!takeFee){
        ...
        _tOwned[address(this)] = _tOwned[address(this)]+buyFEE;  
        ...
    } else {
        ...
        _tOwned[address(this)] = _tOwned[address(this)]+sellFEE;  
        ...
    }
}

You can observe it by calling balanceOf(0x273C36C21Be2049CE275003D46c2ee7Aa15f6bE9):
image

3

Technically, where are the fees going to
Because it deduct the fees from tokens transferred

4

What part of this did you not understand? Or did you even bother to read it?

5

So basically the fees are being added to the balanceof[address(this)], I get it now, so why do I have to provide a tax wallet? Since it basically just send fees to the contract address

6

Can I change the wallet the tax is being sent to another wallet without causing complications
_tOwned[wallet_marketing]+= buyFee;
_tOwned[wallet_marketing]+= sellFee;

7

I don't know dude, you're the one who wrote it, so you're the one who should know the answer to that.

8

You can, but that wallet is used for something else (which - yet again - you're supposed to know)...

In order to "do stuff without causing complications", the best thing that you can do is to define the requirements of your product, and then implement the contract according to these requirements.