OpenZeppelin Forum

ERC1967Proxy - Verification on blockchain explorer fails if using the latest version

Support Upgrades

SKYBITDev3 September 7, 2023, 5:23pm 1

The version of ERC1967Proxy used by OpenZeppelin Hardhat Upgrades plugin is old. So I decided to use the latest version at https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/proxy/ERC1967/ERC1967Proxy.sol instead.

After deployment I attempted to verify on a blockchain explorer and got the error:

Bytecode does not match with the current version of ERC1967Proxy in the Hardhat Upgrades plugin

I filed an issue at https://github.com/OpenZeppelin/openzeppelin-upgrades/issues/870 but nobody has responded.

Please fix it so that the latest version verifies successfully.

Environment

Hardhat with @nomicfoundation/hardhat-verify 1.1.1 and Solidity 0.8.21

ericglau September 11, 2023, 3:39pm 2

The master branch of https://github.com/OpenZeppelin/openzeppelin-contracts is not recommended for general use because that is the active development branch and represents unreleased code.

I've posted a comment on the GitHub issue that the version of the proxy contracts deployed by the Hardhat Plugin is the latest recommended version.

SKYBITDev3 September 12, 2023, 8:37am 3

But the latest release of openzeppelin-upgrades is importing release v4.8.3 of @openzeppelin/contracts.

github.com

OpenZeppelin/openzeppelin-upgrades/blob/a41b4317c0ca368cfc6b98b8fe6c33f480bbb766/packages/core/package.json#L41C18-L41C39


      
          "@openzeppelin/contracts": "4.8.3",

Shouldn't it import the latest, which is v4.9.3?

ericglau September 12, 2023, 6:38pm 4

There were no changes from v4.8.3 to v4.9.3 which affect the proxy contracts for deployment.

SKYBITDev3 September 12, 2023, 8:28pm 5

But it's still preferable to use the latest released code.

Many of the files that ERC1967Proxy imports are different between v4.8.3 and v4.9.3, e.g.:

github.com

OpenZeppelin/openzeppelin-contracts/blob/v4.8.3/contracts/proxy/ERC1967/ERC1967Upgrade.sol

// SPDX-License-Identifier: MIT
// OpenZeppelin Contracts (last updated v4.8.3) (proxy/ERC1967/ERC1967Upgrade.sol)

pragma solidity ^0.8.2;

import "../beacon/IBeacon.sol";
import "../../interfaces/IERC1967.sol";
import "../../interfaces/draft-IERC1822.sol";
import "../../utils/Address.sol";
import "../../utils/StorageSlot.sol";

/**
 * @dev This abstract contract provides getters and event emitting update functions for
 * https://eips.ethereum.org/EIPS/eip-1967[EIP1967] slots.
 *
 * _Available since v4.1._
 *
 * @custom:oz-upgrades-unsafe-allow delegatecall
 */
abstract contract ERC1967Upgrade is IERC1967 {

This file has been truncated. show original

github.com

OpenZeppelin/openzeppelin-contracts/blob/v4.9.3/contracts/proxy/ERC1967/ERC1967Upgrade.sol

// SPDX-License-Identifier: MIT
// OpenZeppelin Contracts (last updated v4.9.0) (proxy/ERC1967/ERC1967Upgrade.sol)

pragma solidity ^0.8.2;

import "../beacon/IBeacon.sol";
import "../../interfaces/IERC1967.sol";
import "../../interfaces/draft-IERC1822.sol";
import "../../utils/Address.sol";
import "../../utils/StorageSlot.sol";

/**
 * @dev This abstract contract provides getters and event emitting update functions for
 * https://eips.ethereum.org/EIPS/eip-1967[EIP1967] slots.
 *
 * _Available since v4.1._
 */
abstract contract ERC1967Upgrade is IERC1967 {
    // This is the keccak-256 hash of "eip1967.proxy.rollback" subtracted by 1
    bytes32 private constant _ROLLBACK_SLOT = 0x4910fdfa16fed3260ed0e7147f7cc6da11a60208b5b9406d12a635614ffd9143;

This file has been truncated. show original

github.com

OpenZeppelin/openzeppelin-contracts/blob/v4.8.3/contracts/interfaces/IERC1967.sol

// SPDX-License-Identifier: MIT
// OpenZeppelin Contracts (last updated v4.8.3) (interfaces/IERC1967.sol)

pragma solidity ^0.8.0;

/**
 * @dev ERC-1967: Proxy Storage Slots. This interface contains the events defined in the ERC.
 *
 * _Available since v4.9._
 */
interface IERC1967 {
    /**
     * @dev Emitted when the implementation is upgraded.
     */
    event Upgraded(address indexed implementation);

    /**
     * @dev Emitted when the admin account has changed.
     */
    event AdminChanged(address previousAdmin, address newAdmin);

This file has been truncated. show original

github.com

OpenZeppelin/openzeppelin-contracts/blob/v4.9.3/contracts/interfaces/IERC1967.sol

// SPDX-License-Identifier: MIT
// OpenZeppelin Contracts (last updated v4.9.0) (interfaces/IERC1967.sol)

pragma solidity ^0.8.0;

/**
 * @dev ERC-1967: Proxy Storage Slots. This interface contains the events defined in the ERC.
 *
 * _Available since v4.8.3._
 */
interface IERC1967 {
    /**
     * @dev Emitted when the implementation is upgraded.
     */
    event Upgraded(address indexed implementation);

    /**
     * @dev Emitted when the admin account has changed.
     */
    event AdminChanged(address previousAdmin, address newAdmin);

This file has been truncated. show original

github.com

OpenZeppelin/openzeppelin-contracts/blob/v4.8.3/contracts/utils/StorageSlot.sol

// SPDX-License-Identifier: MIT
// OpenZeppelin Contracts (last updated v4.7.0) (utils/StorageSlot.sol)

pragma solidity ^0.8.0;

/**
 * @dev Library for reading and writing primitive types to specific storage slots.
 *
 * Storage slots are often used to avoid storage conflict when dealing with upgradeable contracts.
 * This library helps with reading and writing to such slots without the need for inline assembly.
 *
 * The functions in this library return Slot structs that contain a `value` member that can be used to read or write.
 *
 * Example usage to set ERC1967 implementation slot:
 * ```
 * contract ERC1967 {
 *     bytes32 internal constant _IMPLEMENTATION_SLOT = 0x360894a13ba1a3210667c828492db98dca3e2076cc3735a920a3ca505d382bbc;
 *
 *     function _getImplementation() internal view returns (address) {
 *         return StorageSlot.getAddressSlot(_IMPLEMENTATION_SLOT).value;

This file has been truncated. show original

github.com

OpenZeppelin/openzeppelin-contracts/blob/v4.9.3/contracts/utils/StorageSlot.sol

// SPDX-License-Identifier: MIT
// OpenZeppelin Contracts (last updated v4.9.0) (utils/StorageSlot.sol)
// This file was procedurally generated from scripts/generate/templates/StorageSlot.js.

pragma solidity ^0.8.0;

/**
 * @dev Library for reading and writing primitive types to specific storage slots.
 *
 * Storage slots are often used to avoid storage conflict when dealing with upgradeable contracts.
 * This library helps with reading and writing to such slots without the need for inline assembly.
 *
 * The functions in this library return Slot structs that contain a `value` member that can be used to read or write.
 *
 * Example usage to set ERC1967 implementation slot:
 * ```solidity
 * contract ERC1967 {
 *     bytes32 internal constant _IMPLEMENTATION_SLOT = 0x360894a13ba1a3210667c828492db98dca3e2076cc3735a920a3ca505d382bbc;
 *
 *     function _getImplementation() internal view returns (address) {

This file has been truncated. show original

github.com

OpenZeppelin/openzeppelin-contracts/blob/v4.8.3/contracts/utils/Address.sol

// SPDX-License-Identifier: MIT
// OpenZeppelin Contracts (last updated v4.8.0) (utils/Address.sol)

pragma solidity ^0.8.1;

/**
 * @dev Collection of functions related to the address type
 */
library Address {
    /**
     * @dev Returns true if `account` is a contract.
     *
     * [IMPORTANT]
     * ====
     * It is unsafe to assume that an address for which this function returns
     * false is an externally-owned account (EOA) and not a contract.
     *
     * Among others, `isContract` will return false for the following
     * types of addresses:
     *

This file has been truncated. show original

github.com

OpenZeppelin/openzeppelin-contracts/blob/v4.9.3/contracts/utils/Address.sol

// SPDX-License-Identifier: MIT
// OpenZeppelin Contracts (last updated v4.9.0) (utils/Address.sol)

pragma solidity ^0.8.1;

/**
 * @dev Collection of functions related to the address type
 */
library Address {
    /**
     * @dev Returns true if `account` is a contract.
     *
     * [IMPORTANT]
     * ====
     * It is unsafe to assume that an address for which this function returns
     * false is an externally-owned account (EOA) and not a contract.
     *
     * Among others, `isContract` will return false for the following
     * types of addresses:
     *

This file has been truncated. show original

ericglau September 12, 2023, 8:59pm 6

Added a comment in the issue https://github.com/OpenZeppelin/openzeppelin-upgrades/issues/870#issuecomment-1716422933 to help explain the above reasoning.

Topic		Replies	Views	Activity
Unverified ERC1967 Proxy goerli Upgrades etherscan-verify	6	1293	February 25, 2023
Verify hardhat upgradeable proxy on blockscout Upgrades erc20 , proxies , etherscan-verify	3	3648	October 14, 2021
Verification of Proxy and ProxyAdmin failing using Hardhat Upgrades proxies	1	994	April 16, 2021
Upgrades Plugins: Etherscan verification for proxies Announcements proxies , upgrades-plugins , etherscan-verify	7	2508	July 25, 2022
Error verifying proxy with plugin @nomiclabs/hardhat-etherscan Upgrades	4	12931	November 21, 2020