DisableInitializers for UUPS Proxy Contract in the Wizard

Support Upgrades
1

Shouldn't the _disableInitializers() be in the Transparent section and not in the UUPS section?

I'm sorry if I messed this up. I'm still new to Proxy Contracts.

Link to Wizard

Screenshot_2
Screenshot_21095×839 46.9 KB

Screenshot_3
Screenshot_3894×290 15.3 KB

2

Hi,

Can you add more detail to the question? The _disableInitializers is in both constructors when you check Transparent or UUPS on the wizard, but the implementation is in the Initializable contract. So, what do you mean exactly when you say:

Shouldn't the _disableInitializers() be in the Transparent section and not in the UUPS section?

3

Hey,

Sorry. I'm a bit confused about how it should work. I thought it should only be on Transparent contracts and not UUPS since the upgrade call is on the implementation contract.

Maybe I misunderstood it.

4

Hi @yanukadeneth99, please see my comment here on why this is recommended for UUPS. As a best practice it should be done in any implementation contract regardless of proxy type.

5

Thanks for the mention! I will read more about it to understand it better.