Best practice for using ProxyFactory.sol in a Solidity 0.6 project deploying minimal proxies?

abcoathup · August 4, 2020, 12:22am

As of today, what is the best practice for using ProxyFactory.sol in a project (for deploying minimal proxies)? I see in the roadmap the plan is to migrate it to @openzeppelin/contracts, whereas it seems only @openzepplin/upgrades currently includes it but only for Solidity ^0.5.3.

I can of course copy the contract and change the pragma, but I wanted to check if there was a preferred approach I'm missing

abcoathup · August 6, 2020, 3:03am

Hi @msolomon4,

For now the best option is to copy/paste the ProxyFactory.sol so that you can use it with Solidity 0.6 in your project.

There is an initial migration in the solc-0.6 branch. It hasn’t been tested though. Unfortunately, although the contract migration itself is quite straightforward, migrating all of the tests and setup to use Solidity 0.6 will be quite a bit more work that we don’t have the bandwidth to do at the moment.
(from: https://github.com/OpenZeppelin/openzeppelin-sdk/issues/1463#issuecomment-614260573)

github.com

OpenZeppelin/openzeppelin-sdk/blob/solc-0.6/packages/lib/contracts/upgradeability/ProxyFactory.sol

pragma solidity ^0.6.0;

import "./InitializableAdminUpgradeabilityProxy.sol";
import "../cryptography/ECDSA.sol";

contract ProxyFactory {
  
  event ProxyCreated(address proxy);

  bytes32 private contractCodeHash;

  constructor() public {
    contractCodeHash = keccak256(
      type(InitializableAdminUpgradeabilityProxy).creationCode
    );
  }

  function deployMinimal(address _logic, bytes memory _data) public returns (address proxy) {
    // Adapted from https://github.com/optionality/clone-factory/blob/32782f82dfc5a00d103a7e61a17a5dedbd1e8e9d/contracts/CloneFactory.sol
    bytes20 targetBytes = bytes20(_logic);

This file has been truncated. show original

The plan is still to move the proxy contracts to OpenZeppelin Contracts.

msolomon4 · August 6, 2020, 3:15am

Got it, thats the approach I’ve been going with so glad to hear it. Thanks as always @abcoathup!

Topic		Replies	Views
When should I use App.sol in my project? SDK erc20 , proxies	4	2116	August 20, 2020
How to deploy minimal proxies with ProxyFactory deprecated? Contracts	4	2340	January 3, 2023
Why was the ProxyFactory from OpenZeppelin SDK deprecated and not continued in Contracts? Contracts	0	366	September 11, 2021
Using proxy contract with Solidity 0.6? Contracts	2	1478	September 21, 2020
Confusion with minimal proxy deployment contract missing SDK	2	1605	February 28, 2020

Best practice for using ProxyFactory.sol in a Solidity 0.6 project deploying minimal proxies?

Related topics