Hi, I was looking at the __Ownable_init function defined in the OwnableUpgradeable contract, and I couldn't understand why it is needed at all. As far as I can tell, only the __Ownable_init_unchained method is called in the other contracts that inherit from OwnableUpgradeable in this repository. S…

Hi @PaulRBerg , the _init functions have linearized calls to parent initializers, while _init_unchained functions do not. There is some documentation about this here: https://docs.openzeppelin.com/contracts/4.x/upgradeable#multiple-inheritance In the case of OwnableUpgradable, there just happens to…

Great explanation, thanks @ericglau . Now, just to double-check that I got this right. If OwnableUpgradeable had a parent initializer to call, it would call the _init_unchained function of that hypothetical parent contract, wouldn't it?

[image] PaulRBerg: If OwnableUpgradeable had a parent initializer to call, it would call the _init_unchained function of that hypothetical parent contract, wouldn't it? Yes, the _init functions internally call _init_unchained functions.

Hey @ericglau , I think I understand the paragraph in the link conceptually, but I don't find an example that _init does call parents' initializers. For example, for this line in the contract AccessControlUpgradeable, the __AccessControl_init function does not call any other _init functions. Am I mis…

Hi @maxareo , here is an example where an _init function calls _init_unchained. In this example it calls it's parent's parent's _init_unchained and then its own.

Thanks @ericglau . It seems a bit arbitrary to me. Is there any rules with _init functions? Please take a look at the snippet below. Should the _init functions for all inherited contracts be included in the initialize() function? contract UpgradeableTestToken is ContextUpgradeable, OwnableUpgradeabl…

Would also like to expand this discussion to the DiamondStorage equivalent (which will be used in 5.x I believe). With this pattern, there is also no constructor, so initialize needs to be called manually. So if you wanted to make an upgradable Governor, would this be the appropriate thing to do: /…

[image] maxareo: Thanks @ericglau . It seems a bit arbitrary to me. Is there any rules with _init functions? Please take a look at the snippet below. Should the _init functions for all inherited contracts be included in the initialize() function? contract UpgradeableTestToken is ContextUpgradeab…

[image] kiko: Would also like to expand this discussion to the DiamondStorage equivalent (which will be used in 5.x I believe). With this pattern, there is also no constructor, so initialize needs to be called manually. So if you wanted to make an upgradable Governor, would this be the appropr…

Thanks @ericglau . It would be great if OZ can make a blog post on this topic. Guidelines and advices on best practices given in an organized and systematic way can benefit the community greatly.

If he doesn't use it, what can happen?

Why keep "__Ownable_init" beside "__Ownable_init_unchained"?

Support Upgrades

Topic		Replies	Views
Initialize contracts with _init and _init_unchained Upgrades	1	902	January 10, 2024
ERC20PausableUpgradeable unchained Upgrades erc20 , upgrades	2	655	May 19, 2023
Upgradeable `init` vs `init_unchained` - a follow up question to a closed thread Smart Contracts	0	477	April 20, 2023
Difference between __init and __init_unchained Upgrades erc721 , erc1155	4	4307	February 27, 2023
The purpose of `__{ContractName}_init_unchained` from upgradeable contracts Smart Contracts erc721 , proxies	0	718	August 5, 2021

Why keep "__Ownable_init" beside "__Ownable_init_unchained"?

Related topics