Hey everyone! So I’m trying to create a Forwarder contract that converts all received ETH/tokens to Chai and sends the Chai to a user’s address. The address that Chai gets forwarded to is the owner of the Forwarder contract, so each user should have their own Forwarder contract. As a result, I figur…

It works! Thanks a bunch @abcoathup :grinning: Seems the culprit was using a forked mainnet to run the tests. When using an ordinary ganache instance, the test passes for both (1) a new project using your code and (2) the original project. With a forked mainnet, both fail. I sure do love the fork …

Hi @msolomon4 , [image] msolomon4: I’d also like to be able to upgrade the underlying logic of the Forwarder contract, and, since the proxy contracts delegate calls to this contract, my understanding is all proxy contracts would consequently be updated by simply updating the logic contract. M…

Hey @abcoathup , thanks for the response! [image] abcoathup: My understanding is that minimal proxies are not upgradeable. We can change the logic contract that future minimal proxies point to, but can’t change existing minimal proxies. That is my understanding as well—that the proxy itself c…

Hi @msolomon4 , Using OpenZeppelin ProxyFactory I can create a Forwarder from the ForwarderFactory. Have a look at the contracts and test below. Forwarder.sol pragma solidity ^0.5.0; import "@openzeppelin/contracts-ethereum-package/contracts/ownership/Ownable.sol"; import "@openzeppelin/upgrades/…

Hmm, and that test passed for you @abcoathup ? I’ve tried replicating your setup above but it hasn’t changed anything. The only difference I can think of is that I’m using Truffle instead of the @openzeppelin/test-enviornment to leverage additional ganache-cli functionality. As a result my test looks…

Hi @msolomon4 , The test passes. I converted to a Truffle Test (though I am a convert of OpenZeppelin Test Environment as it is fast) and it still passes. You may want to setup a new project with the cut down versions of the contracts I provided above to get it working. //const { accounts, contra…

Hi @msolomon4 , Lesson learnt for me too, I didn’t run your code as is. Though I would encourage using OpenZeppelin’s ProxyFactory if appropriate. Same too for OpenZeppelin Test Environment.

Yep, I’ll definitely be sticking with ProxyFactory since it’s working well. And surely a bit safer than manually pulling out the one function I need :slight_smile: I do want to use OpenZeppelin’s Test Environment, though am just waiting for support of a few of the ganache-cli parameters listed in t…

Just created the issue here , in case anyone was interested in following it.

Issues initializing EIP-1167 minimal proxies deployed with factory contract

Support

Topic		Replies	Views
How to deploy minimal proxies using ProxyFactory in Truffle? Contracts proxies	7	5639	August 3, 2020
Proxy Contracts Forwarding Calls To Zero Address Despite Initialization Upgrades	2	721	November 30, 2020
Calling initialize() after deployment from a factory reverts SDK erc20	4	1108	July 15, 2020
Programmatically deploying upgradeable proxies Upgrades proxies , upgrades	11	4743	March 2, 2022
Deploying Upgradeable Proxies and Proxy Admin from Factory contract Upgrades	41	10224	May 17, 2022

Issues initializing EIP-1167 minimal proxies deployed with factory contract

Related topics