How to change this function?

Smart Contracts
1

how to change this function?

function setMaxTxPercent(uint256 maxTxPercent) external onlyOwner() {
_maxTxAmount = _tTotal.mul(maxTxPercent).div(
10**3

Is this alright?

function setMaxTxPercent(uint256 maxTxPercent) external onlyOwner() {
require(maxTxPercent > 0.1, "Cannot set transaction amount less than 0.1 percent!");
_maxTxAmount = _tTotal.mul(maxTxPercent).div(
10**2

Recommendation from Audit company

○ Considered as good practice is that transaction amount restrictions
not to be below 0.1% of total supply per transaction.

TypeError: Operator > not compatible with types uint256 and rational_const 1 / 10
--> Test1.sol:536:18:
|
536 | require (maxTxPercent > 0.1, "Cannot set transaction amount less than 0.1 percent

im not sure how to change this function?

2

Use this instead:

function setMaxTxAmount(uint256 maxTxPPT) external onlyOwner() {
    require(maxTxPPT > 0, "Cannot set transaction amount less than 1 PPT!");
    _maxTxAmount = _tTotal.mul(maxTxPPT).div(10**3);
}

PPT stands for Parts Per Thousand (in opposed to percent, which means for Parts Per Hundred).

3

Thank you. I will try this way

4

i tried , i getting error

DeclarationError: Undeclared identifier.
--> undefined/MetaGamers.sol:536:18:
|
536 | require (maxTxPPT > 0, "Cannot set transaction amount less than 1 PPT!");
| ^^^^^^^^

is this alright?

function setMaxTxPercent(uint256 maxTxPercent) external onlyOwner() {
require (maxTxPercent > 1, "Cannot set transaction amount less than 1 percent!");
_maxTxAmount = _tTotal.mul(maxTxPercent).div(
10**3
);

5

The name of the input parameter in your function is probably (still) maxTxPercent.
I recommend taking some basic programming classes before jumping to smart contracts.

6

i know what i doing wrong, i didn't change the name function to setMaxTxAmount. thanks