Error using ERC20 transferFrom in a buy function selling tokens

[abcoathup]

@PreciousChicken

So to conclude: in the code above there is no way; at least the way I’ve structured these contracts; for the ‘from’ element (currently pointing to msg.sender) to point to the actual holder of the coins in a programmatic way?

Correct. transferFrom is used with approve where first a token holder approves an allowance and then calls a smart contract that can use that allowance with transferFrom.

@PreciousChicken

So what would be the v3 way of selling tokens for Ether? Would the preferred way be to do it in just one contract? Or are we just saying that the whole concept of selling tokens for Ether is just so 2017 it isn’t the done thing anymore!

You can still use OpenZeppelin Contracts 2.x to create a crowdsale, though I recommend looking at Points to consider when creating a fungible token (ERC20, ERC777)

You could potentially add your token to a decentralized exchange and provide liquidity. Though a working solution requiring your token should come first.

Distributing tokens to users of your solution is also a way to go.

@PreciousChicken

, I’m just trying to extend my familiarisation here, rather than trying to put anything into production; but it never hurts to be precise with language, so thank you.

I think non-fungible tokens (such ERC721) are fun to experiment with. I also like experiments with personal tokens.