Best practice for fix point math and decimal conversion

[abcoathup]

Hi @antoncoding,

I suggest having a look the discussion in Designing Fixed Point Math in OpenZeppelin Contracts for some potential ideas.

As for ERC20 decimals there were a couple of relevant posts in the discussion:

Designing Fixed Point Math in OpenZeppelin Contracts

I found this list of token decimal breakdown by percentage (https://github.com/ethereum/EIPs/issues/724#issuecomment-333155336). I looked at the original list and it seems like there aren’t any tokens with more than 18 decimals. Here’s the breakdown if you don’t want to follow the link: decimals Percent of tokens 0 10% 1 0.5% 2 3.1% 3 1.5% 4 1% 5 1% 6 2.6% 7 0.5% 8 21%…

Designing Fixed Point Math in OpenZeppelin Contracts

I would just note, that token decimals have nothing to do with fixed point math, as all token amounts are actually integers, and decimals property is just a hint for UI regarding how to present token amounts to a user.

I'm interested to hear from other members of the community on this topic.