Hi @frangio , and @aquiladev , I got the same issue with truffle upgrades. Added a new variable as address type, getting this issue. if the plugin does not support it, how can I do it manually? New variables should be placed after all existing inherited variables Upgraded __gap to an incompatibl…

Ok, sorry we didn't mention this earlier, but you seem to be using Truffle. Gap resizing is only available on Hardhat for technical reasons (Truffle doesn't give us enough information to confidently assess that layouts are compatible). Opened GitHub issue https://github.com/OpenZeppelin/openzeppeli…

@skyclean906 Can you provide an example of how your variables are defined in the old and new versions of your contract? The error indicates that the gap array size was not adjusted correctly in the new version.

Hi @ericglau , Thanks for your quick help. // Old version .... uint256[46] private __gap; // New version .... address public royaltyRegister; uint256[45] private __gap; but I'm also getting the error. New variables should be placed after all existing inherited varia…

Is there any suggestion message after the error? For example, something like Set __gap array to size <number> Can you please provide the following info? The complete output of running your script, including all of the error message texts. A minimum reproducible example, containing the old and new…

[image] ericglau: npm list @openzeppelin/upgrades-core [image] Hi @ericglau , the command result is here. [image] And here is error detail. Please help me to check. Thanks!

We can't see any errors in what you've shared so far, and we can't reproduce it locally either. The following storage upgrade works correctly as expected: contract V1 { uint256[46] private __gap; } contract V2 { address public royaltyRegister; uint256[45] private __gap; } Can you plea…

Hi @frangio , @ericglau I uploaded the full code of two version files. https://drive.google.com/drive/folders/1yhKuQuSHzvkENvYh0uQFdAje2m_rKFwe?usp=sharing

These are not the contracts you are having issues with. It would not be labelled abstract. Please share the entire codebase. If you can't do so, please put together a minimal reproduction example that you can fully share and that we can use to reproduce the issue.

Hi @frangio , @ericglau , I pushed the full code here for the issue. some info added on readme file. [image] GitHub - skyclean906/market-upgrading-check: upgrading issue - checking upgrading issue - checking. Contribute to skyclean906/market-upgrading-check development by creating …

Bad storage gap resize with Truffle

Support Upgrades

Topic		Replies	Views
Bad storage gap resize when adding variables and reducing gap Upgrades	11	935	July 28, 2023
Add new state variable to base contract using storage gaps Upgrades	4	1489	January 31, 2021
Using storage gaps with `hardhat-upgrades` Upgrades	5	3288	December 6, 2022
Upgrade add new storage variable Contracts	2	433	September 12, 2021
Bad storage gap resize when adding inherited contract Upgrades	3	839	December 16, 2022

Bad storage gap resize with Truffle

Related topics